Use multiprocessing for Pika event consumer #6760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricwo
approved these changes
Sep 25, 2020
|
Spent time testing it on Kubernetes instance today — events get streamed by |
|
That's great! I'll start working on backporting to 1.10 as soon as it is merged |
|
It might take a while, by the way — my other PR (this one: #6943) is waiting to be merged since yesterday :( |
|
Ooof ok, well I can work on backport from this branch too |
|
Could not update branch. Most likely this is due to a merge conflict. Please update the branch manually and fix any issues. |
|
@ricwo one test here is failing again - do you know what's wrong with it? Also failing on my backport branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)