Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvements #6276

Merged
merged 17 commits into from
Sep 2, 2020
Merged

API improvements #6276

merged 17 commits into from
Sep 2, 2020

Conversation

pheel
Copy link
Contributor

@pheel pheel commented Jul 24, 2020

Proposed changes:

  • When Rasa is run with --enable-api, exceptions incurred as a result of a request are redirected to the HTTP response. This is nice, but it's useful to also have them show up in ones favorite stream handler via the Python logger.
  • When attempting to load an outdated model, Rasa terminates with an UnsupportedModelError or UnsupportedDialogueModelError. This is problematic for users that have access to the /train route, but not the file system from which models are retrieved. This allows Rasa to boot so that such users can retrain.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @rgstephens will take a look at it as soon as possible ✨

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Super cool 🚀

changelog/6276.improvement.rst Outdated Show resolved Hide resolved
changelog/6276.improvement.rst Outdated Show resolved Hide resolved
rasa/core/interpreter.py Outdated Show resolved Hide resolved
@pheel pheel requested a review from wochinge August 17, 2020 22:17
tests/core/test_run.py Outdated Show resolved Hide resolved
tests/core/test_run.py Outdated Show resolved Hide resolved
changelog/6276.improvement.rst Outdated Show resolved Hide resolved
@pheel pheel requested a review from wochinge August 19, 2020 15:07
@pheel pheel requested a review from wochinge August 21, 2020 19:16
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@wochinge wochinge merged commit 1f184c7 into RasaHQ:master Sep 2, 2020
@pheel pheel mentioned this pull request Oct 20, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants