Convert entity values from Duckling to strings for testing #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erohmensing
approved these changes
Jun 22, 2020
rasa/core/test.py
Outdated
Comment on lines
234
to
241
| if ( | ||
| k == ENTITY_ATTRIBUTE_VALUE | ||
| and EXTRACTOR in set(r) | ||
| and r[EXTRACTOR] == "DucklingHTTPExtractor" | ||
| ): | ||
| # convert values from duckling to strings for evaluation as | ||
| # target values are all of type string | ||
| r[k] = str(r[k]) |
There was a problem hiding this comment.
Re the conversation we had in slack, i'm not sure if it makes more sense to change it for all extractors (e.g. if someone created a custom RegexExtractor that pulled a number in int instead of str) if the target values are always strings
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
In our tests all entity values are of type string. However, values from duckling can be of any type. In order to correctly compare predicted and target entities, we need to convert the entity values from duckling to strings during our evaluation.
related to #5977
Status (please check what you already did):
black(please check Readme for instructions)