Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies based on the dependabot check + fix prompt-toolkit dependency #5635

Merged
merged 9 commits into from
Apr 21, 2020

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Apr 15, 2020

Proposed changes:

  • Update dependencies based on the dependabot check.
  • Correctly specify the minimum supported Python version because the fixed version of prompt-toolkit requires Python 3.6.1.

Status (please check what you already did):

  • updated the documentation
  • updated the changelog (please check changelog for instructions)

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting all these in one PR 🚀 Due to the change in the minimum required Python version, just a "comment" for now

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
changelog/5636.bugfix.rst Outdated Show resolved Hide resolved
@alwx alwx requested a review from wochinge April 16, 2020 08:38
@erohmensing
Copy link
Contributor

@alwx my changes fix shell for regular input, but the button questions are still throwing bc those weren't fixed -- there are other places to check, so i'm going to remove my changes here, then open a new PR with them to make stuff clearer

@alwx alwx force-pushed the updated-deps branch 3 times, most recently from 7482056 to 137f0ab Compare April 21, 2020 08:48
@Ghostvv Ghostvv merged commit 0997a58 into master Apr 21, 2020
@tmbo tmbo deleted the updated-deps branch May 1, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants