Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generator predict #5529

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Remove generator predict #5529

merged 4 commits into from
Mar 30, 2020

Conversation

dakshvar22
Copy link
Contributor

@dakshvar22 dakshvar22 commented Mar 30, 2020 •
edited
Loading

Proposed changes:

  • Remove call to tf.data.Dataset.from_generator while making predictions. Repeated calls result in memory leak.
  • It also increases inference speed by a factor of around 4x!

Status (please check what you already did):

  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@dakshvar22 dakshvar22 requested a review from ricwo March 30, 2020 17:03
ricwo
ricwo approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks a lot for the fix 🎉 👍

@dakshvar22 dakshvar22 merged commit 3e1d666 into 1.9.x Mar 30, 2020
@dakshvar22 dakshvar22 deleted the remove-generator-predict branch March 30, 2020 17:47
@amn41
Copy link
Contributor

amn41 commented Mar 30, 2020

nice work @dakshvar22 !

@smn
Copy link

smn commented Mar 30, 2020

❤️ and 🍰 from us here https://turn.io -- this is awesome!

@dakshvar22 dakshvar22 mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dakshvar22 @amn41 @smn @ricwo