Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default value for weight_sparsity in response selector to 0 #5505

Merged
merged 2 commits into from
Mar 26, 2020
Merged

set default value for weight_sparsity in response selector to 0 #5505

merged 2 commits into from
Mar 26, 2020

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Mar 26, 2020 •
edited
Loading

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Ghostvv Ghostvv requested a review from dakshvar22 March 26, 2020 14:50
@Ghostvv Ghostvv mentioned this pull request Mar 26, 2020
Closed
4 tasks
@Ghostvv Ghostvv merged commit 9b5d58d into 1.9.x Mar 26, 2020
@Ghostvv Ghostvv deleted the fix-response-1.9 branch March 26, 2020 17:58
@dakshvar22 dakshvar22 mentioned this pull request Mar 27, 2020
Merged
4 tasks
@dakshvar22 dakshvar22 mentioned this pull request Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakshvar22 dakshvar22 dakshvar22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghostvv @dakshvar22