Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return scale loss #5482

Merged
merged 12 commits into from
Mar 24, 2020
Merged

return scale loss #5482

merged 12 commits into from
Mar 24, 2020

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Mar 24, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Ghostvv Ghostvv requested a review from tabergma March 24, 2020 14:20
@Ghostvv Ghostvv added this to the Rasa 1.9 milestone Mar 24, 2020
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

rasa/nlu/classifiers/diet_classifier.py Show resolved Hide resolved
@tabergma
Copy link
Contributor

Also, I think we should add a changelog entry.

@Ghostvv
Copy link
Contributor Author

Ghostvv commented Mar 24, 2020

@tabergma I updated changelog and changed the logic of scaling loss: now it only turns on, if at least 1 example in a batch is learned (making training loss curve jump to higher values after some epoch)

don't know what to do with DeepSource check: I didn't change anything regarding the bugs, it raises

@tabergma
Copy link
Contributor

DeepSource checks the complete file you touched. If the checks are not critical, I guess you can ignore them for now. I think we are fine here. But ideally all of them are tackled.

@tttthomasssss tttthomasssss merged commit 15a30ef into master Mar 24, 2020
@Ghostvv Ghostvv deleted the scale_loss branch March 24, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any intent without an extracted entity fails to be classified correctly after upgrading to 1.8.1
3 participants