Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain no-root user for SDK image #5404

Merged
merged 3 commits into from
Mar 11, 2020
Merged

explain no-root user for SDK image #5404

merged 3 commits into from
Mar 11, 2020

Conversation

wochinge
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge changed the base branch from master to 1.8.x March 11, 2020 08:12
@wochinge wochinge requested a review from indam23 March 11, 2020 08:16
indam23
indam23 approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@indam23 indam23 merged commit c266fa5 into 1.8.x Mar 11, 2020
@indam23 indam23 deleted the sdk-no-root branch March 11, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indam23 indam23 indam23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @indam23