Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache_dir config for save HFTransformersNLP pre-trained model data. #5389

Merged
merged 9 commits into from
Mar 18, 2020
Merged

Add cache_dir config for save HFTransformersNLP pre-trained model data. #5389

merged 9 commits into from
Mar 18, 2020

Conversation

XiaofeiQian
Copy link
Contributor

@XiaofeiQian XiaofeiQian commented Mar 7, 2020

Proposed changes:

  • Add cache_dir for save HFTransformersNLP pre-trained model data

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Hsiaofei Tsien added 5 commits March 7, 2020 15:59
Add an optional path to a specific directory to download and cache the pre-trained model weights.
update cache_dir doc
set cache_dir default to null
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 The assigned reviewer will take a look at it as soon as possible✨

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @HatuneMiku 🎉Can you please also add a changelog entry?

docs/nlu/components.rst Outdated Show resolved Hide resolved
Hsiaofei Tsien and others added 2 commits March 18, 2020 11:59
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @HatuneMiku 💪

@wochinge wochinge merged commit ad98964 into RasaHQ:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants