Fix special token cleanup when using language models #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabergma
approved these changes
Mar 3, 2020
| def cleanup_tokens( | ||
| token_ids_string: List[Tuple[int, Text]], delimiter: Text | ||
| ) -> Tuple[List[int], List[Text]]: | ||
| """Utility method to apply specific delimiter based cleanup on list of tokens""" |
There was a problem hiding this comment.
We should use the full docstring symtax, e.g. including Args and Return. But we also have another issue for that.
There was a problem hiding this comment.
Thanks for pointing it out. Will address it as part of that issue.
Comment on lines
+18
to
+19
| token_ids, token_strings = zip(*token_ids_string) | ||
| return token_ids, token_strings |
There was a problem hiding this comment.
Suggested change
| token_ids, token_strings = zip(*token_ids_string) | |
| return token_ids, token_strings | |
| return zip(*token_ids_string) |
There was a problem hiding this comment.
@tabergma Get a type error if I do that, that's why had to first unpack it and then return.
There was a problem hiding this comment.
ok, thanks for the explanation, then I guess it is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)