Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating mattermost connector to use bot accounts #5250

Merged
merged 13 commits into from
Feb 20, 2020
Merged

Updating mattermost connector to use bot accounts #5250

merged 13 commits into from
Feb 20, 2020

Conversation

btotharye
Copy link
Contributor

Updated the mattermost connector to use bot accounts.

Proposed changes:

  • Use version 2.2 of mattermostwrapper that allows for new token option
  • Updated mattermost connector to use new token in the init call.
  • Updated documentation to reflect new options for bot token.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

…eature and updated docs and connector accordingly
@btotharye
Copy link
Contributor Author

still have to add the changelog in, working on that

@btotharye
Copy link
Contributor Author

@wochinge I can't remember who I was talking to about this, but this allows for using bot accounts now for mattermost which is a lot more secure so this all works and I just verified and updated the docs some.

Let me know if there are any questions, not sure who should review it.

@wochinge
Copy link
Contributor

Thanks a lot, Brian!
@akelad Your squad or Prod / Loop?

@btotharye
Copy link
Contributor Author

sorry didn't realize there were tests, I fixed those now as well.

@btotharye
Copy link
Contributor Author

@wochinge I think there is an issue with the coveralls in the github actions since it got moved from Travis there is an error about the token. Just an FYI.

@akelad
Copy link
Contributor

akelad commented Feb 19, 2020

@wochinge you guys feel free to take that over

@degiz degiz added this to the Rasa 1.8 milestone Feb 20, 2020
@tmbo tmbo self-assigned this Feb 20, 2020
@tmbo tmbo self-requested a review February 20, 2020 14:22
@tmbo tmbo merged commit 23af1a3 into RasaHQ:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants