Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tf without gpu support by default #4994

Merged
merged 4 commits into from
Jan 16, 2020
Merged

use tf without gpu support by default #4994

merged 4 commits into from
Jan 16, 2020

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Dec 18, 2019

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge changed the base branch from master to 1.6.x December 18, 2019 15:32
@wochinge wochinge marked this pull request as ready for review December 18, 2019 15:41
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if I understand correctly, installing tensorflow==1.15.0 brings binaries for both cpu and gpu but pinning to tensorflow-cpu does not?
Do we also support a GPU based docker image?
If yes, we should pin to tensorflow-gpu there.

@wochinge
Copy link
Contributor Author

@dakshvar22 So tensorflow included only the cpu packages until 1.15. tensorflow==1.15 included both gpu and cpu packages. For tensorflow 2 it's again the old pattern: tensorflow==2.0 is only cpu, while tensorflow-gpu==2.0 is the gpu package. So by using tensorflow-cpu==1.15 we just go back to the way we have been releasing things before.

@wochinge
Copy link
Contributor Author

@dakshvar22 Can I merge this?

@dakshvar22
Copy link
Contributor

@wochinge Sounds good!

@wochinge wochinge merged commit 7c14020 into 1.6.x Jan 16, 2020
@wochinge wochinge deleted the use-tf-cpu-only branch January 16, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants