Let external events and reminders trigger intents #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
November 5, 2019 15:02
# Conflicts: # rasa/core/events/__init__.py
JEM-Mosig
added
type:discussion 👨👧👦
|
How do we synchronize the release of this feature in rasa with the corresponding changes in the Rasa-SDK and Rasa X? |
wochinge
reviewed
Jan 21, 2020
| parser.parse("2018-09-03T11:41:10.128172"), | ||
| name="my_reminder", | ||
| kill_on_user_message=True, | ||
| ) | ||
|
|
||
|
|
||
| def test_json_parse_reminder_cancelled(): | ||
| # fmt: off |
There was a problem hiding this comment.
As far as I know it prevents black from formatting it. You'd have to try out how the black formatting would look and if we actually need the fmt: off
wochinge
reviewed
Jan 21, 2020
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
wochinge
reviewed
Jan 21, 2020
wochinge
reviewed
Jan 21, 2020
wochinge
reviewed
Jan 21, 2020
wochinge
approved these changes
Jan 21, 2020
Yay!!! Thank you for your help! 🙏 And sorry for the many issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
/conversations/<conversation_id>/inject-intent, which injects a user message with given intent and entities into the conversation/conversations/<conversation_id>/executenow triggers deprecation warning"is_external": TrueStatus (please check what you already did):
black(please check Readme for instructions)Reminder*events