New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename `url` parameter to `host` for custom tracker store #4734

Closed

akelad opened this issue Nov 6, 2019 · 0 comments · Fixed by #4808

Assignees

Labels

area:rasa-oss 🎡 type:maintenance 🔧

Contributor

akelad commented Nov 6, 2019

Right now the way a custom tracker store is loaded up the parameter for the url is called url. All our other tracker stores use the parameter host instead, so we should make this consistent.
https://github.com/RasaHQ/rasa/blob/master/rasa/core/tracker_store.py#L127

The text was updated successfully, but these errors were encountered:

akelad added the area:rasa-oss 🎡 label

wochinge added the type:maintenance 🔧 label

erohmensing self-assigned this

erohmensing mentioned this issue

change url to host in custom tracker store #4808

Merged

5 tasks

erohmensing closed this as completed in #4808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment