Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect warning about WhitespaceTokenizer #4605

Closed
tabergma opened this issue Oct 14, 2019 · 6 comments
Closed

Incorrect warning about WhitespaceTokenizer #4605

tabergma opened this issue Oct 14, 2019 · 6 comments
Assignees
@michiboo
Labels
help wanted stale type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones.

Comments

@tabergma
Copy link
Contributor

The warning in https://rasa.com/docs/rasa/user-guide/evaluating-models/#intent-classification is not true anymore. Our WhitespaceTokenizer splits Brian's into multiple tokens.

We should update or remove the warning.
@tabergma tabergma added the type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. label Oct 14, 2019
@michiboo
Copy link
Contributor

michiboo commented Jan 5, 2020

Hi Can I have a go at this issue?

@tabergma
Copy link
Contributor Author

tabergma commented Jan 6, 2020

@michiboo Sure, go ahead 🚀 Thanks!

@erohmensing
Copy link
Contributor

@michiboo are you still interested in working on this issue?

@michiboo
Copy link
Contributor

@erohmensing Hi yes, sorry for the delay I will open a PR soon

@michiboo michiboo mentioned this issue Apr 16, 2020
Merged
4 tasks
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 18, 2020
@tabergma
Copy link
Contributor Author

fixed in #5643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michiboo michiboo

Labels
help wanted stale type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tabergma @erohmensing @michiboo @EmmaWightman