Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable kwargs for service post("/model/train") #4596

Closed
lsgome opened this issue Oct 10, 2019 · 9 comments
Closed

Enable kwargs for service post("/model/train") #4596

lsgome opened this issue Oct 10, 2019 · 9 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/server Issues focused running rasa as server (e.g. via `rasa run`) type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@lsgome
Copy link

lsgome commented Oct 10, 2019

Description of Problem:
Currently the http / model / train service does not allow you to define extra parameters that exist on the command line, for example the augmentation_factor.

Overview of the Solution:
Change the / model / train service to include in the request body a dictionary where the kwargs parameter can be set. Pass the parameter to train_async.

Examples (if relevant):
Request:
{
"domain": ...
"config": ...
"nlu": ...
"kwargs": ...
}

Definition of Done:
Test training by changing the augmentation_factor parameter

@lsgome lsgome added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Oct 10, 2019
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀@msamogh will get back to you about it soon!✨

@wochinge wochinge added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Oct 16, 2019
@wochinge
Copy link
Contributor

Hi @lsgome , sounds like a great idea! Do you want to work on it?

@lsgome
Copy link
Author

lsgome commented Oct 22, 2019

Yes, I can do.

@wochinge
Copy link
Contributor

Amazing @lsgome ! Let me know if you need any help! I assign you for now so that nobody starts working on it at the same time, but feel free to un-assign you in case you change your mind.

@stale
Copy link

stale bot commented Feb 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale label Feb 3, 2020
@tmbo tmbo removed the status:stale label Feb 3, 2020
@joejuzl joejuzl added the area:rasa-oss/server Issues focused running rasa as server (e.g. via `rasa run`) label Jan 28, 2021
@theanht1
Copy link
Contributor

theanht1 commented Mar 3, 2021

@wochinge does anyone take this issue? I could work for this enhancement

@lsgome
Copy link
Author

lsgome commented Mar 3, 2021 via email

@wochinge
Copy link
Contributor

wochinge commented Mar 3, 2021

Feel free to start working on it @theanht1 You can also share an early draft in case you need feedback / help. Just tag me in the PR then 🚀

@m-vdb
Copy link
Collaborator

m-vdb commented Mar 14, 2022

Fixed in #8132

@m-vdb m-vdb closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/server Issues focused running rasa as server (e.g. via `rasa run`) type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

7 participants