Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

categorical slot should have category other so that other values could be mapped to it #2674

Closed
Ghostvv opened this issue Oct 29, 2018 · 5 comments
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@Ghostvv
Copy link
Contributor

Ghostvv commented Oct 29, 2018

Rasa Core version: master

Python version: 0.3.6

Operating system (windows, osx, ...): macOS

Issue:
Right now categorical slot requires to name its all possible values in domain.yml, though for practical reasons it is convenient to have general category like other, to which all values not mentioned in the list are mapped

Content of domain file (if used & relevant):

@tmbo tmbo transferred this issue from RasaHQ/rasa_core Mar 21, 2019
@stale
Copy link

stale bot commented Jun 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale label Jun 19, 2019
@Ghostvv Ghostvv added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed status:stale labels Jun 19, 2019
@wochinge wochinge added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. labels Nov 18, 2019
@wochinge
Copy link
Contributor

Makes sense to me 👍 Should we remove the discussion label?

@Ghostvv
Copy link
Contributor Author

Ghostvv commented Dec 19, 2019

if it makes sense to do, then we can consider it to be discussed 😀

but then I would allow to create a slot with only one category, then effectively it'll become two categories due to addition of other

@Ghostvv Ghostvv removed the type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. label Dec 19, 2019
@indam23
Copy link
Contributor

indam23 commented Jan 14, 2020

should there be any warning for values mapped to other? and what should happen if someone puts a literal "other" as a value in the domain?

@indam23
Copy link
Contributor

indam23 commented Jan 14, 2020

@Ghostvv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

3 participants