Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the priority order of slot mappings in which slots are filled #11390

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Jul 27, 2022

Proposed changes:

  • Fixes 2.x regression (broken in 3.x) where the expected priority order in which slot mappings are applicable is from the beginning to the end of the slot mappings list specified in the domain (more context here)
  • Clarifies this implicit priority order in the docs.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review July 27, 2022 12:22
@ancalita ancalita requested a review from a team as a code owner July 27, 2022 12:22
@ancalita ancalita requested review from indam23 and removed request for a team July 27, 2022 12:22
Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I just left some phrasing suggestions & suggestions to shorten the test.

tests/core/test_actions.py Outdated Show resolved Hide resolved
tests/core/test_actions.py Outdated Show resolved Hide resolved
docs/docs/domain.mdx Outdated Show resolved Hide resolved
changelog/11390.bugfix.md Outdated Show resolved Hide resolved
@ancalita ancalita requested a review from indam23 July 27, 2022 12:56
@ancalita ancalita enabled auto-merge July 27, 2022 12:57
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11390--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita merged commit 537e655 into 3.2.x Jul 27, 2022
@ancalita ancalita deleted the ATO-219-priority-of-slot-mapping-opposite-from-rasa-2 branch July 27, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants