Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow EndpointConfig as parameter type given to AwaitableTrackerStore.create() method #11368

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Allow EndpointConfig as parameter type given to AwaitableTrackerStore.create() method #11368

merged 2 commits into from
Jul 20, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Jul 20, 2022 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11368--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita marked this pull request as ready for review July 20, 2022 07:50
@ancalita ancalita requested a review from a team as a code owner July 20, 2022 07:50
@ancalita ancalita requested review from sanchariGr and indam23 and removed request for a team July 20, 2022 07:50
indam23
indam23 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on a roll this week 🚀

@ancalita ancalita merged commit f139bed into 3.2.x Jul 20, 2022
@ancalita ancalita deleted the ATO-222-awaitable-tracker-store-wrapper-does-not-allow-endpoint-config-as-an-obj-argument branch July 20, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indam23 indam23 indam23 approved these changes

@sanchariGr sanchariGr Awaiting requested review from sanchariGr sanchariGr is a code owner automatically assigned from RasaHQ/atom-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ancalita @indam23