Extract slots with mapping conditions during form activation #11149
Conversation
ancalita
requested review from
losterloh,
m-vdb and
indam23
and removed request for
a team
| f"these events: {events_as_str}." | ||
| ) | ||
|
|
||
| tracker.update_with_events(extraction_events, domain) |
There was a problem hiding this comment.
is there any reason why this is called here and at the same time the function returns the events? As far as I understand, the processor will update the tracker with the events returned by this function
There was a problem hiding this comment.
I have to update the tracker immediately in order for the tracker to update its tracker.slots attribute, which gets used in the for loop below (L610-612) to extract the prefilled slots. Because the tracker is temporary, it won't duplicate the events in the actual tracker that the processor updates.
|
@ancalita given Arjaan response on the ticket, I think this should wait a review from Lukas and/or Melinda. I initially started giving a review in order to go faster but now we're waiting on customer feedback. |
@m-vdb @ancalita |
|
BTW I'll defer to @losterloh review here and remove myself from the reviewers. I'll also remove Melinda as she's off this week |
…of-a-form-for-the-intent-that-starts-the-form
|
🚀 A preview of the docs have been deployed at the following URL: https://11149--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
ancalita
deleted the
SB-101-slot-mapping-from-entity-in-context-of-a-form-for-the-intent-that-starts-the-form
branch
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)