Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract new event streaming for loop into separate TrackerStore method #11088

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Extract new event streaming for loop into separate TrackerStore method #11088

merged 5 commits into from
Apr 20, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Apr 20, 2022 •
edited
Loading

Proposed changes:

  • Refactor TrackerStore.stream_events method by extracting new event streaming for loop into separate TrackerStore method

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita requested a review from losterloh April 20, 2022 13:39
@ancalita ancalita marked this pull request as ready for review April 20, 2022 13:39
@ancalita ancalita requested a review from a team as a code owner April 20, 2022 13:39
@ancalita ancalita removed the request for review from a team April 20, 2022 13:39
losterloh
losterloh reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@losterloh losterloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need changelog entries for pure refactorings like this one?

rasa/core/tracker_store.py Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
@ancalita
Copy link
Member Author

@losterloh I can add a misc changelog entry.

@ancalita ancalita requested a review from losterloh April 20, 2022 14:48
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11088--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita enabled auto-merge (squash) April 20, 2022 16:10
@ancalita ancalita merged commit 5868d0d into main Apr 20, 2022
@ancalita ancalita deleted the anca/tracker-store-refactoring branch April 20, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losterloh losterloh losterloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ancalita @losterloh