Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entity influence_conversation flag #10899

Merged
merged 11 commits into from
Mar 10, 2022
Merged

Add entity influence_conversation flag #10899

merged 11 commits into from
Mar 10, 2022

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Feb 15, 2022 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • updated some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)
  • bump training data version (references changed to constant throughout codebase in a separate PR)

@indam23 indam23 linked an issue Feb 16, 2022 that may be closed by this pull request
Allow global influence_conversation per entity instead of per intent #10852
Closed
5 tasks
@indam23 indam23 changed the base branch from 3.0.x to main February 16, 2022 16:13
@indam23 indam23 requested a review from a team as a code owner February 16, 2022 16:13
@indam23 indam23 requested review from chandrikas and removed request for a team and chandrikas February 16, 2022 16:13
@indam23 indam23 enabled auto-merge (squash) March 7, 2022 13:27
ancalita
ancalita reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Left a few suggestions for refactoring - I'm also wondering if we need a unit test to make sure that stories are not influenced by the unfeaturized entity defined through the new flag?

rasa/shared/core/domain.py Outdated Show resolved Hide resolved
rasa/shared/core/domain.py Outdated Show resolved Hide resolved
rasa/shared/core/domain.py Outdated Show resolved Hide resolved
@indam23
Copy link
Contributor Author

indam23 commented Mar 7, 2022 •
edited
Loading

I'm also wondering if we need a unit test to make sure that stories are not influenced by the unfeaturized entity defined through the new flag?

👍 I added to the stories in data/test_yaml_stories/stories_unfeaturized_entities.yml to test this in the existing unit test test_domain.py::test_create_train_data_unfeaturized_entities - because of the format version bump it is hard to see this change 🙈

@indam23 indam23 requested a review from ancalita March 9, 2022 10:53
ancalita
ancalita reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯 Added few minor suggestions, the only one to look into is actually the setter method for Domain.entities.

rasa/shared/core/domain.py Show resolved Hide resolved
rasa/shared/core/domain.py Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://10899--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@indam23 indam23 requested a review from ancalita March 10, 2022 11:56
ancalita
ancalita approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 🙌🏼

rasa/shared/core/domain.py Show resolved Hide resolved
@indam23 indam23 merged commit 813216d into main Mar 10, 2022
@indam23 indam23 deleted the entity_influence_convo_flag branch March 10, 2022 13:13
@indam23 indam23 mentioned this pull request Mar 29, 2022
Closed
2 tasks
@indam23 indam23 linked an issue Apr 20, 2022 that may be closed by this pull request
Provide to option to prevent an entity to ever influence rasa core predictions #5751
Closed
3 tasks
@indam23 indam23 mentioned this pull request Apr 20, 2022
Closed
3 tasks
indam23 added a commit that referenced this pull request Jul 27, 2022
@indam23
Add entity influence_conversation flag (#10899)
17acf02 
* add influence_conversation flag to entities

* bump training data format version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@indam23 @ancalita @rasabot