remove CompositionView

[jfcarmonag]

CompositionView has been deprecated

Proposed changes:

• Remove CompositionView

Status (please check what you already did):

• added some tests for the functionality
• updated the documentation
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[CLAassistant]

All committers have signed the CLA.

[wochinge]

Thanks for the contribution! Can you please also adapt the usage in Line 129?

[ahopkins]

FWIW, HTTPMethodView and CompositionView are not interchangeable.

[ahopkins]

You probably want to change this:

        if not isinstance(route.handler, CompositionView):
            handlers = [
                (list(route.methods)[0], route.name.replace("rasa.server.", ""))
            ]
        else:
            handlers = [
                (method, find_route(v.__name__, endpoint) or v.__name__)
                for method, v in route.handler.handlers.items()
            ]

to this:

        handlers = [
            (list(route.methods)[0], route.name.replace("rasa.server.", ""))
        ]

[jfcarmonag]

Done. Thanks.

[jfcarmonag]

It didn't pass the Code Quality test. I don't understand why. Any help?

[tayfun]

It didn't pass the Code Quality test. I don't understand why. Any help?

@jfcarmonag Are you able to install and run black on rasa/core/utils.py file? See the exact error here: https://github.com/RasaHQ/rasa/runs/4704649427?check_suite_focus=true

Black is basically the code formatter so that we have consistent and uniform code.

[jfcarmonag]

There were some problems with Codeclimate that I didn't understand, but I don't see the messages anymore because I tried to merge again. Any help?

[tayfun]

There were some problems with Codeclimate that I didn't understand, but I don't see the messages anymore because I tried to merge again. Any help?

Neither of the two errors are on your side @jfcarmonag . The docs one I'm asking around if we need to change netlify config and the other error seems to be related to poetry which an upgrade should fix. I'm making some inquiries to get both resolved. Thanks for your patience.

[tayfun]

This is now merged, thanks for the contribution @jfcarmonag

Doc build failure was not a blocker because it is not required (but anyway fixed) and the Windows test failure that I thought was due to Poetry error fixed itself on a subsequent run.