Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add single event schema #10572

Merged
merged 4 commits into from
Dec 22, 2021
Merged

add single event schema #10572

merged 4 commits into from
Dec 22, 2021

Conversation

kalkbrennerei
Copy link
Contributor

@kalkbrennerei kalkbrennerei commented Dec 22, 2021 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@kalkbrennerei kalkbrennerei marked this pull request as ready for review December 22, 2021 14:05
@kalkbrennerei kalkbrennerei requested a review from a team as a code owner December 22, 2021 14:05
@kalkbrennerei kalkbrennerei requested review from carlad and removed request for a team December 22, 2021 14:05
@carlad
Copy link
Contributor

carlad commented Dec 22, 2021

Looks good @kalkbrennerei 👍
There's just a single test in the test/shared/utils/schemas/test_events.py. Do you think it covers everything we need to test of this schema?

@kalkbrennerei kalkbrennerei merged commit 4e8441a into 3.0.x Dec 22, 2021
@kalkbrennerei kalkbrennerei deleted the single-event-schema branch December 22, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlad carlad carlad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalkbrennerei @carlad