Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs on CI #278

Closed
jakirkham opened this issue Oct 16, 2019 · 5 comments
Closed

Build docs on CI #278

jakirkham opened this issue Oct 16, 2019 · 5 comments

Comments

@jakirkham
Copy link
Member

We recently started adding docs to ucx-py. ( #273 ) Would be good to test that they build as part of CI. One option would be to do this as part of gpuCI. Not sure how this is handled. Another would be to enable the beta ReadTheDocs feature for building PRs. We could also do both.

@jakirkham jakirkham mentioned this issue Oct 16, 2019
@pentschev
Copy link
Member

@jakirkham could you confirm if this is still relevant? I'm not sure what's the current status.

@jakirkham
Copy link
Member Author

It's not done currently. Would be nice to do.

@quasiben
Copy link
Member

quasiben commented Jun 1, 2020

So folks are aware of what we are doing now:

  1. RTD does not have libnuma installed on build machines and UCX throw an error on import if it does not exist. To over come this issue I build and uploaded a UCX conda package without numa

  2. RTD is currently pointed at my branch of ucx-py which points to the nonuma conda package: https://github.com/quasiben/ucx-py/blob/56482570fe37d99c2df73ba2e8c478c047052e74/conda/environments/builddocs_py37.yml#L19

  3. when we merge doc edits I merge my branch with latest edits and manually trigger a build

This system is not great...

@jakirkham
Copy link
Member Author

FWIW RTD is working on adding apt-get support ( readthedocs/readthedocs.org#8065 ). So that might be another way to address installing libnuma

@jakirkham
Copy link
Member Author

OPS recently enabled PR builds for RTD, which addresses the original issue.

On the libnuma point, have a rough PR ( #734 ) to use the new RTD apt support, which they are deploying next Tuesday afternoon. So that should address this secondary issue.

Given this will go ahead and close this out as the original issue was already addressed and the 2nd point soon will be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants