Skip to content

Increase cython-lint line length - #8374

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jcrist:expand-cython-line-length
Jul 13, 2026
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jcrist:expand-cython-line-length

Conversation

@jcrist

@jcrist jcrist commented Jul 13, 2026

Copy link
Copy Markdown
Member

The new copyright headers are long, and lead to cython-lint failures. I don't like that this forces us to increase the line length limit everywhere, but it's the easiest fix for now.

The new copyright headers are _long_, and lead to `cython-lint`
failures. I don't like that this forces us to increase the line length
limit everywhere, but it's the easiest fix for now.
@jcrist jcrist self-assigned this Jul 13, 2026
@jcrist
jcrist requested a review from a team as a code owner July 13, 2026 19:38
@jcrist jcrist added the improvement Improvement / enhancement to an existing function label Jul 13, 2026
@jcrist
jcrist requested a review from KyleFromNVIDIA July 13, 2026 19:38
@jcrist jcrist added the non-breaking Non-breaking change label Jul 13, 2026
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 084b0b14-cffb-42ff-84a6-6b42f8fc6dcb

📥 Commits

Reviewing files that changed from the base of the PR and between 89b5804 and ac8ab51.

📒 Files selected for processing (1)
  • pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated code style settings to allow lines up to 105 characters.
    • Updated the copyright header wording.

Walkthrough

Changes

Lint Configuration

Layer / File(s) Summary
Configuration metadata and lint limit
pyproject.toml
Updates the SPDX header to include “NVIDIA CORPORATION & AFFILIATES” and raises the Cython lint maximum line length from 95 to 105.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: gforsyth, kylefromnvidia, csadorf, bdice

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: widening the cython-lint line-length limit.
Description check ✅ Passed The description is directly related to the changeset and explains why the lint limit was increased.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jameslamb

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 920d012 into NVIDIA:main Jul 13, 2026
105 checks passed
@jcrist
jcrist deleted the expand-cython-line-length branch July 13, 2026 21:00
@coderabbitai coderabbitai Bot mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants