Skip to content

Remove stale sklearn example xfail - #8259

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
csadorf:remove-gpr-noisy-xfail
Jun 12, 2026
Merged

Remove stale sklearn example xfail#8259
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
csadorf:remove-gpr-noisy-xfail

Conversation

@csadorf

@csadorf csadorf commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Remove the strict xfail for gaussian_process::plot_gpr_noisy, which now XPASSes in latest-deps sklearn example CI with NumPy 2.4.

Closes #8260

@csadorf
csadorf requested a review from a team as a code owner June 12, 2026 14:03
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2026
@csadorf
csadorf requested a review from viclafargue June 12, 2026 14:03
@copy-pr-bot

copy-pr-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR removes a single xfail configuration entry from the scikit-learn upstream test examples. The entry marked gaussian_process::plot_gpr_noisy as expected-to-fail under NumPy >= 2.4 due to np.reshape no longer accepting newshape as a keyword argument. The removal indicates the test now passes or the incompatibility has been resolved.

Changes

Configuration cleanup

Layer / File(s) Summary
Remove numpy>=2.4 xfail for plot_gpr_noisy
python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml
Deleted the xfail block for gaussian_process::plot_gpr_noisy that was conditioned on numpy>=2.4 due to np.reshape keyword argument incompatibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rapidsai/cuml#7960: Both PRs address the scikit-learn upstream xfail-examples.yaml configuration for gaussian_process::plot_gpr_noisy and its np.reshape keyword argument compatibility with NumPy>=2.4.

Suggested labels

Cython / Python

Suggested reviewers

  • viclafargue
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove stale sklearn example xfail' directly and clearly summarizes the main change: removing an outdated xfail entry from the examples configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the removal of an xfail entry and referencing the related issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf

csadorf commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 1df193b

@csadorf

csadorf commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 21e6735 into NVIDIA:main Jun 12, 2026
111 checks passed
@csadorf
csadorf deleted the remove-gpr-noisy-xfail branch June 12, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] scikit-learn examples fail on strict XPASS in plot_gpr_noisy

4 participants