Add regex-flags member variable to internal libcudf reprog class - #22994
Merged
Conversation
📝 WalkthroughWalkthroughThe PR updates regex program declarations and implementation so ChangesRegex program flags
Search count namespace cleanup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mhaseeb123
approved these changes
Jun 26, 2026
vyasr
approved these changes
Jun 26, 2026
Contributor
|
/merge |
copy-pr-bot Bot
pushed a commit
that referenced
this pull request
Jun 29, 2026
) Adds new member variable to hold the regex-flags specified by the regex-program interface so that it may be referenced more easily later for fast-path checking. This is some common changes needed in #22178 and #21936 and will help reduce the size of the changes for both and hopefully reduce confusion on the changes needed there. Cleanup of related files is included as well. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - Vyas Ramasubramani (https://github.com/vyasr) URL: #22994
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new member variable to hold the regex-flags specified by the regex-program interface so that it may be referenced more easily later for fast-path checking. This is some common changes needed in #22178 and #21936 and will help reduce the size of the changes for both and hopefully reduce confusion on the changes needed there.
Cleanup of related files is included as well.
Checklist