Add additional regex gtests for contains, count, findall, and replace - #22874
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR extends regex behavior coverage in CUDF string functions by adding unit tests across three test files. Tests validate nullable alternation branches, bounded repetition constraints, newline handling in dot patterns, alternation priority semantics, and lazy quantifier behavior in ChangesString Regex Edge Case Coverage
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly Related PRs
Suggested Reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
…#22874) Adds some additional gtests for regex patterns to help validate optimizations in follow on PRs. This is part of splitting out some of the work for #21936 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Basit Ayantunde (https://github.com/lamarrr) URL: #22874
Description
Adds some additional gtests for regex patterns to help validate optimizations in follow on PRs.
This is part of splitting out some of the work for #21936
Checklist