-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Split libcudf-streaming tests and benchmarks into a dedicated conda package #22871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e4fb619
9fc527b
ff16a16
2f9e6f6
ba4dc27
49dd8b1
80aad37
028f733
a0938ca
cd32b45
8408ed9
7985231
5440690
d85191e
faa150f
a40c82c
c897ce4
edca51e
b0b989d
abc5fd5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,8 @@ | |
| include(${rapids-cmake-dir}/cpm/gbench.cmake) | ||
| rapids_cpm_gbench(BUILD_STATIC) | ||
|
|
||
| set(CUDF_STREAMING_BENCHMARK_INSTALL_DIR bin) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason we're putting these straight into
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To me this feels like an improvement over the status quo. We can easily start typing
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK if having these executables on the path is useful to you that's fine with me. |
||
|
|
||
| add_library(bench_utils INTERFACE) | ||
| target_sources(bench_utils INTERFACE utils/random_data.cu) | ||
| target_compile_options(bench_utils INTERFACE $<$<COMPILE_LANGUAGE:CUDA>:--expt-extended-lambda>) | ||
|
|
@@ -18,6 +20,7 @@ if(CUDF_STREAMING_HAVE_COMM) | |
| set_target_properties( | ||
| bench_shuffle | ||
| PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CUDF_STREAMING_BINARY_DIR}/benchmarks" | ||
| OUTPUT_NAME "libcudf_streaming_bench_shuffle" | ||
| CXX_STANDARD 20 | ||
| CXX_STANDARD_REQUIRED ON | ||
| CXX_EXTENSIONS ON | ||
|
|
@@ -32,7 +35,7 @@ if(CUDF_STREAMING_HAVE_COMM) | |
| install( | ||
| TARGETS bench_shuffle | ||
| COMPONENT benchmarking | ||
| DESTINATION bin/benchmarks/libcudf_streaming | ||
| DESTINATION "${CUDF_STREAMING_BENCHMARK_INSTALL_DIR}" | ||
| EXCLUDE_FROM_ALL | ||
| ) | ||
| else() | ||
|
|
@@ -43,6 +46,7 @@ add_executable(bench_partition "bench_partition.cpp") | |
| set_target_properties( | ||
| bench_partition | ||
| PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CUDF_STREAMING_BINARY_DIR}/benchmarks" | ||
| OUTPUT_NAME "libcudf_streaming_bench_partition" | ||
| CXX_STANDARD 20 | ||
| CXX_STANDARD_REQUIRED ON | ||
| CXX_EXTENSIONS ON | ||
|
|
@@ -56,14 +60,15 @@ target_link_libraries( | |
| install( | ||
| TARGETS bench_partition | ||
| COMPONENT benchmarking | ||
| DESTINATION bin/benchmarks/libcudf_streaming | ||
| DESTINATION "${CUDF_STREAMING_BENCHMARK_INSTALL_DIR}" | ||
| EXCLUDE_FROM_ALL | ||
| ) | ||
|
|
||
| add_executable(bench_pack "bench_pack.cpp") | ||
| set_target_properties( | ||
| bench_pack | ||
| PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CUDF_STREAMING_BINARY_DIR}/benchmarks" | ||
| OUTPUT_NAME "libcudf_streaming_bench_pack" | ||
| CXX_STANDARD 20 | ||
| CXX_STANDARD_REQUIRED ON | ||
| CXX_EXTENSIONS ON | ||
|
|
@@ -78,7 +83,7 @@ target_link_libraries( | |
| install( | ||
| TARGETS bench_pack | ||
| COMPONENT benchmarking | ||
| DESTINATION bin/benchmarks/libcudf_streaming | ||
| DESTINATION "${CUDF_STREAMING_BENCHMARK_INSTALL_DIR}" | ||
| EXCLUDE_FROM_ALL | ||
| ) | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.