Derive per-chunk memory reservation from scan statistics - #22846
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change threads an estimated chunk size estimate through the partition planning pipeline. A new optional field on ChangesPartition Chunk Estimation Pipeline
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
Simply use the estimated chunk size (already computed) for the memory reservation. I ran TPC-H locally (single-gpu, sf1k) and didn't notice any notable regressions. xref NVIDIA#22796 Authors: - Matthew Murray (https://github.com/Matt711) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) URL: NVIDIA#22846
Description
Simply use the estimated chunk size (already computed) for the memory reservation. I ran TPC-H locally (single-gpu, sf1k) and didn't notice any notable regressions.
xref #22796
Checklist