Fix groupby.apply columns axis name for row-like UDF results - #22809
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
galipremsagar
marked this pull request as ready for review
June 8, 2026 20:34
📝 WalkthroughWalkthroughGroupBy.apply for row-like Series outputs now explicitly preserves the columns-axis name after transposing and concatenating results. The corresponding test entries are removed from the failure registry, indicating those tests now pass with the fix. ChangesGroupBy apply columns metadata
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
vyasr
approved these changes
Jun 10, 2026
Contributor
Author
|
/merge |
abigalekim
pushed a commit
to abigalekim/cudf
that referenced
this pull request
Jun 12, 2026
…22809) Fixes a `cudf.pandas` correctness bug in `DataFrameGroupBy.apply`: when the UDF returns a row-like Series (e.g. `x.iloc[0]`), the result's columns axis now inherits that Series' name to match pandas, instead of being left unnamed. Re-enables the now-passing `test_callable_result_dtype_frame` cases in the pandas-test plugin. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: NVIDIA#22809
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a
cudf.pandascorrectness bug inDataFrameGroupBy.apply: when the UDF returns a row-like Series (e.g.x.iloc[0]), the result's columns axis now inherits that Series' name to match pandas, instead of being left unnamed.Re-enables the now-passing
test_callable_result_dtype_framecases in the pandas-test plugin.Checklist