Use CCCL overflow utils instead of custom overflow logic - #22593
Merged
Conversation
📝 WalkthroughWalkthroughThis PR refactors overflow detection across cuDF by replacing manual ChangesOverflow Detection Refactoring
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
vyasr
approved these changes
May 19, 2026
| auto const is_within_byte_range = | ||
| std::cmp_greater_equal(row_group_file_offset, bytes_to_skip) and | ||
| (not bytes_to_read.has_value() or | ||
| cuda::add_overflow<size_t>(bytes_to_skip, bytes_to_read.value()).overflow or |
Contributor
There was a problem hiding this comment.
Signpost for the next reviewer, this line is the meaningful change in this PR. The rest is just clang-format.
mhaseeb123
approved these changes
May 19, 2026
davidwendt
approved these changes
May 20, 2026
3 tasks
Member
Author
|
/merge |
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uncovered this cleanup opportunity while working on #22465.
This PR replaces cudf's custom overflow handling logic with the overflow utilities provided by CCCL. Note that although these utilities are under the
cuda::namespace, they are available on both host and device.Checklist