Skip to content

Conversation

@galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Dec 29, 2023

Description

This PR sorts results in Index.difference & union in the early exit scenarios similar to: pandas-dev/pandas#51346

On pandas_2.0_feature_branch:

= 110 failed, 101331 passed, 2091 skipped, 952 xfailed, 312 xpassed in 1064.30s (0:17:44) =

This PR:

= 87 failed, 101354 passed, 2091 skipped, 952 xfailed, 312 xpassed in 1004.34s (0:16:44) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Dec 29, 2023
@galipremsagar galipremsagar self-assigned this Dec 29, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 29, 2023 01:58
@galipremsagar galipremsagar requested review from isVoid and removed request for a team December 29, 2023 01:58
@galipremsagar galipremsagar changed the title Sort Index.difference results for early exit scenarios Sort Index.difference & union results for early exit scenarios Dec 29, 2023
@galipremsagar galipremsagar merged commit 1c54354 into rapidsai:pandas_2.0_feature_branch Dec 29, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants