-
Notifications
You must be signed in to change notification settings - Fork 982
[REVIEW] Upgrade pandas to 1.5
#11617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Upgrade pandas to 1.5
#11617
Conversation
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
shwina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment -- thanks, Prem!
| result_col = column.column_empty( | ||
| len(self._column), dtype="bool", masked=True | ||
| raise TypeError( | ||
| f"expected a string or a sequence-like object, not " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, in 1.5. we also further restricted startswith/endswith to only accept a tuple specifically to mirror the stdlib
In [15]: "f".endswith(["f", "g"])
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
Input In [15], in <cell line: 1>()
----> 1 "f".endswith(["f", "g"])
TypeError: endswith first arg must be str or a tuple of str, not list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did see that change, I'll be opening a follow-up PR because that will need some discussions & libcudf side changes too.
mroeschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for this!
msadang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@gpucibot merge |
Description
This PR introduces
pandas-1.5support incudf. The changes include:group_keyssupport ingroupbyfordask_cudfto work: Add support forgroup_keysingroupby#11659zfillupdates to matchpandas-1.5behavior: Update zfill to match Python output #11634whereAPI: Ability to inspect a scalar value if it can be fit into the existing dtype, similar to: DOC: Clarify DataFrame.where tries to maintain dtype of DataFrame when providing fill_value pandas-dev/pandas#48373ValueErrortoTypeErrorwhen an unknown category is being set to aCategoricalColumnArrowIntervalTyperelated import that has resulted incudfto error on import itself.IntervalColumn.to_pandas.booleandtype is being set to aNumericalColumn.patis None inSeries.str.startswith&Series.str.endswith.IntervalDtype.to_pandaswith appropriate versioning.get_window_boundssignature changes.Checklist