Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Stop using private RMM macros in cudf #18189

Open
bdice opened this issue Mar 6, 2025 · 3 comments
Open

[BUG] Stop using private RMM macros in cudf #18189

bdice opened this issue Mar 6, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@bdice
Copy link
Contributor

bdice commented Mar 6, 2025

Describe the bug
cuDF is using private RMM macros and should stop relying on these.

Sources:
https://github.com/search?q=repo%3Arapidsai%2Fcudf+%2F%28%3F-i%29RMM_%5BA-Z_%5D*%5C%28%2F&type=code

The specific examples I see are:

Pull requests like #18108 should be unnecessary.

Expected behavior
No RMM_... macros are used in the cudf repository.

xref: rapidsai/rmm#1848

@bdice bdice added the bug Something isn't working label Mar 6, 2025
@bdice
Copy link
Contributor Author

bdice commented Mar 6, 2025

@pmattione-nvidia -- could you investigate a fix for the JNI side?

@pmattione-nvidia
Copy link
Contributor

Seems like the easiest thing to do is just to copy/paste the macro body in place at those locations. The thing I don't know is whether RMM has a dedicated interface to do these actual things that I should call instead

@bdice
Copy link
Contributor Author

bdice commented Mar 9, 2025

@pmattione-nvidia Most macros are duplicated across RAPIDS libraries, to avoid reliance on internal implementation details of other libraries (example: rapidsai/kvikio#653). I would recommend implementing macros named specifically for the cuDF JNI layer.

The macro in to_arrow_device should probably be a cuDF macro instead of an RMM macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants