Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the Number of Filtered Parquet Rowgroups (IO Metadata) to pylibcudf #18106

Open
wants to merge 6 commits into
base: branch-25.04
Choose a base branch
from
Open

Expose the Number of Filtered Parquet Rowgroups (IO Metadata) to pylibcudf #18106

wants to merge 6 commits into from

Conversation

JigaoLuo
Copy link

Description

Expose the Number of Filtered Parquet Rowgroups (IO Metadata) to pylibcudf

Closes #18074

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@JigaoLuo JigaoLuo requested a review from a team as a code owner February 26, 2025 20:30
@JigaoLuo JigaoLuo requested review from wence- and vyasr February 26, 2025 20:30
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Feb 26, 2025
@mroeschke
Copy link
Contributor

/ok to test

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 26, 2025
@JigaoLuo
code linted
530afad 
Signed-off-by: Jigao Luo <[email protected]>
@mroeschke
Copy link
Contributor

/ok to test

@mroeschke
Copy link
Contributor

/ok to test

@mroeschke
Copy link
Contributor

Thanks for the pull request @JigaoLuo. Looks like so far the tests you've added are passing (the other CI failures are unrelated).

Could you also add unit tests for the other APIs that you mentioned were failing in the linked issue?

@JigaoLuo
Copy link
Author

JigaoLuo commented Mar 1, 2025

@mroeschke Thanks for testing. I have a very simple test but always failing in my setup due to the issue I mentioned.
The test is bad styled and can be improved later.

@JigaoLuo
Copy link
Author

JigaoLuo commented Mar 1, 2025

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@mroeschke mroeschke

@JigaoLuo JigaoLuo

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: No status
libcudf
Status: External Contribution
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Exposing the Number of Filtered Parquet Rowgroups (IO Metadata) to pylibcudf, if makes sense
2 participants
@JigaoLuo @mroeschke