Load libcufile.so with RTLD_NODELETE flag #177
Merged
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Will rebase once #175 is merged. |
Member
|
Thanks Gigon! 😄 |
Member
|
cc @madsbk (for awareness) |
Member
|
rerun tests |
ajschmidt8
approved these changes
Dec 3, 2021
jakirkham
approved these changes
Dec 3, 2021
quasiben
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a following up fix for #158.
GDS team suggested using
RTLD_NODELETEwhen calling dlopen() so that the library is not unloaded.They will fix the issue by adding
-z nodeletein the link flags when building libcufile.so in the future releases.With this fix, cuCIM will work with GDS regardless of the versions (v1.1[failing] or not).