-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate using scikit-build-core
#645
Comments
More history on build changes made in issue: #305 |
👍 ! A few notes: scikit-build's core has been refactored / rebuilt into scikit-build-core, which is a PEP517 build-backend that can be added to pyproject.toml. There is outstanding pybind11 support. Support for optional built components with pure python fallback is planned. |
scikit-build
scikit-build-core
Side note: the current pip install command is failing for me:
|
What Python version are you using? |
Based on the output of |
Right only Python 3.9 & 3.10 are supported atm Python 3.11 is in the works: rapidsai/build-planning#3 |
Indeed 3.11. Great to hear that it is on the roadmap for support. Another side note, dependency specification / resolution issue noting here, although I do not know if we can resolve it with current Python packaging standards and pip's resolver: Adding |
This is for the conda packages or the wheels? Conda packages use Wheels have a named suffix. So |
Also here is cuCIM's Python 3.11 PR: #704 |
Note that since this issue was first created the rest of RAPIDS that was using scikit-build has been migrated to scikit-build-core. |
This is with the workflow:
That package had the |
Yeah the move to the suffixed naming convention is relatively new. Would imagine there are still a few projects that will need updates. Would recommend filing an issue on the project repo where the old dependency name is used and link them back to current recommendation in the README |
Additional discussion and ideas on this here: #710 |
Currently cuCIM contains
When building wheels, the first two are built together as part of a CMake build. The result of which is bundled into a Python wheel with the last component, which is then shipped
The result is wheels are treated as pure, which caused some issues ( #641 ). Though those can be worked around
That said, it may be worth using scikit-build-core to streamline all of this and create a single wheel
One consideration is some users just use the Pure Python portion. Maybe we can add a flag to enable/disable the C++ build
Edit: To update to scikit-build-core as that is preferred
The text was updated successfully, but these errors were encountered: