Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong function is used for calculating dense score #40

Open
dangkhoasdc opened this issue Mar 12, 2025 · 0 comments
Open

Wrong function is used for calculating dense score #40

dangkhoasdc opened this issue Mar 12, 2025 · 0 comments

Comments

@dangkhoasdc
Copy link
Contributor

In the doc of dense_scores, it is mentioned that: torch.mean is dedicated to training

func
Either torch.sum or torch.mean. torch.mean is dedicated to training and
torch.sum is dedicated to inference.

However, in your training function of SparseEmb, you use torch.sum instead. So which one is preferable for training? I guess it should be torch.mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant