Skip to content

Fix light and dark theming #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
raphaelsalaja opened this issue Oct 1, 2023 · 0 comments
Open

Fix light and dark theming #1

raphaelsalaja opened this issue Oct 1, 2023 · 0 comments
Assignees
@raphaelsalaja
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@raphaelsalaja
Copy link
Owner

raphaelsalaja commented Oct 1, 2023 •
edited
Loading

Problem

There is an issue regarding some UI elements not having their respective dark and light mode variants. This appears due to two reasons.

1. Lack of Defined Colour

Text(title).font(.title3).fontDesign(.rounded).fontWeight(.bold)

2. Explicit Colours

.background(Color(.white))

Additional Context

Can be prevented by defining a base theme, or by colours with in-built variants.
@raphaelsalaja raphaelsalaja added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Oct 1, 2023
@raphaelsalaja raphaelsalaja self-assigned this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphaelsalaja raphaelsalaja

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raphaelsalaja