Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom dimensions in GA pageviews and events #287

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ttmarek
Copy link
Contributor

@ttmarek ttmarek commented Sep 20, 2018

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works.
  • I have added all necessary documentation (if appropriate)

What was done

These changes adds support for custom dimensions when tracking events and page views in Google Analytics. The API adopted here was directly taken directly from the discussion in #278.

Associated Issues

@ttmarek
Copy link
Contributor Author

ttmarek commented Sep 20, 2018

If you'd like to test these changes they are available in:

npm install @redux-beacon/google-analytics@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom dimensions and metrics
1 participant