Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the region of the AMI to tag #443

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Include the region of the AMI to tag #443

merged 1 commit into from
Jul 23, 2021

Conversation

davidcassany
Copy link
Contributor

Signed-off-by: David Cassany [email protected]

@davidcassany davidcassany requested a review from mudler July 23, 2021 09:46
@davidcassany
Copy link
Contributor Author

davidcassany commented Jul 23, 2021 •
edited
Loading

@mudler the only idea that comes to my mind is adding the region of the image to tag, just in case it filter by the default region... I have not really tested this script. I just successfully executed the command aws ec2 create-tags ... using the ami id from this job and the first region in the list eu-north-1. So I am relatively confident this won't break.

What I am unsure about is the root cause of the failure seen in this job

mudler
mudler approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here, let's see 👀 !

@mudler mudler merged commit b16cf43 into master Jul 23, 2021
@mudler mudler deleted the improve_aws_ami_uploader branch July 23, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidcassany @mudler