amazon: Enhance AMI name and tags #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably breaks #399 so dont merge it before that one is merge, this one is simpler to rebase. |
This patch adds the github.sha to the build name of the AMI so we can easily identify where the image came from if pushed from CI and to be able to upload more than one image per day on CI as well. Also adds it to the tags, and add a new Flavor tag, so we can use data lifecycle policies to auto remove images and search for an X flavor by using those tags. Also adds that tag to the aws_upload.sh script to tag the recovery images as "recovery" The default value for no git_sha is none. Signed-off-by: Itxaka <[email protected]>
|
rebased and reworked a bit on adding the same tags to the aws_upload.sh script |
davidcassany
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the github.sha to the build name of the AMI so we can
easily identify where the image came from if pushed from CI and to be
able to upload more than one image per day on CI as well.
Also adds it to the tags, and add a new Flavor tag, so we can use data
lifecycle policies to auto remove images and search for an X flavor by
using those tags.
The default value for no git_sha is none.
Signed-off-by: Itxaka [email protected]