Publish Vanilla AMI in EC2 #399
Conversation
davidcassany
force-pushed
the
publish_vanilla_ami
branch
5 times, most recently
from
e98c89c
to
2a19734
Compare
davidcassany
force-pushed
the
publish_vanilla_ami
branch
from
2a19734
to
16c5c9e
Compare
davidcassany
force-pushed
the
publish_vanilla_ami
branch
from
16c5c9e
to
34a7d46
Compare
| @@ -187,7 +187,7 @@ jobs: | |||
| yq w -i $MANIFEST.remote 'luet.repositories[0].type' 'docker' | |||
| yq w -i $MANIFEST.remote 'luet.repositories[0].urls[0]' $FINAL_REPO | |||
| sudo -E MANIFEST=$MANIFEST.remote make local-iso | |||
| COS_VERSION=$(yq r packages/cos/collection.yaml 'version') | |||
| COS_VERSION=$(yq r packages/cos/collection.yaml 'packages.[0].version') | |||
There was a problem hiding this comment.
I was pretty sure I changed this already, was it lost on some commit?
There was a problem hiding this comment.
I was also surprised by that... I thought it was also solved already... 🤷♂️
.github/build.yaml.gomplate
Outdated
|
|
||
| {{{ if $config.publishing_pipeline }}} | ||
|
|
||
| publish-vanilla-ami-{{{ $flavor }}}: |
There was a problem hiding this comment.
do we really need to push the raw image per flavor? AFAIK we only use the recovery part of it, are the recoveries different between flavors?
There was a problem hiding this comment.
I say this, because we should push ubuntu/fedora images so we should remove the skip_images_flavor: ["fedora","ubuntu"] but that would make the vanilla upload 3 times
There was a problem hiding this comment.
See this is only active for $config.publishing_pipeline which is only active for master.yaml and master.yaml also includes
skip_tests_flavor: ["fedora","ubuntu"]
skip_images_flavor: ["fedora","ubuntu"] which causes it only to be computed per opensuse
There was a problem hiding this comment.
yeah, but we would need to publish ami images for both systems, which means it will trigger the vanilla image upload 3 times
There was a problem hiding this comment.
Ok I see, you suggest to name it without a flavor
There was a problem hiding this comment.
What about now, it is statically forced for opensuse, it is named without a flavor and it only applies for master workflow.
| run: | | ||
| make aws_vanilla_ami | ||
|
|
||
| ami-publish-{{{ $flavor }}}: |
There was a problem hiding this comment.
Currently this will only upload the suse image.
| @@ -1,13 +1,16 @@ | |||
| name: "Default deployment" | |||
| stages: | |||
| rootfs.after: | |||
| - name: "Repart image" | |||
| - if: '[ -f "/run/cos/recovery_mode" ]' | |||
This commit adds a makefile target to publish the cOS Vanilla image that might be later on used on Packer templates. It also adds an additional CI job to publish it as part of the CI workflow. Related to #378 Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
publish_vanilla_ami
branch
from
7e52c7e
to
132a8b3
Compare
|
|
||
| echo "Tagging Snapshot" | ||
| aws ec2 create-tags --resources "${snap_id}" \ | ||
| --tags Key=Name,Value=${disk_name} Key=Project,Value=cOS Key=GITHUB_SHA,Value=$github_sha |
There was a problem hiding this comment.
more interesting is the Key=Flavor,Value=$FLAVOR here, as it will allow us to create deletion policies based on the flavor images
|
Right, merged, now lets see if the master build behaves good, changes on the master workflow are always tricky 🤞 |
This commit adds post-* hooks where the after hooks were originally defined. After hooks are moved to happen straight in sequence after the after-*-chroot hooks. The main motivation for such a change is having a hook that includes the partition, the running system and the deployed image all mounted and easily accessible. Signed-off-by: David Cassany <[email protected]>
This commit adds a makefile target to publish the cOS Vanilla image
that might be later on used on Packer templates.
It also adds an additional CI job to publish it as part of the CI
workflow.
Related to #378
Signed-off-by: David Cassany [email protected]