Use a different cache per OS flavor #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <[email protected]>
mudler
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
While I'm ok with this, it shouldn't be required. I'm puzzled.. If we are facing this it means there is some underlying problem, which makes me think might be related to #297 - if image hashing is not unique in the cases of images which are a "join" between final images, it might explain also that case as well
|
I think I understand now the underlying issue, I've opened mudler/luet#234 to track it. Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to ensure caches between flavor are not mixed. In https://github.com/rancher-sandbox/cOS-toolkit/suites/3187960702/artifacts/73622493 the built ISO is using a Fedora based image for recovery while it should be an openSUSE based one. This PR is to enforce caches are separate for each flavor.
Signed-off-by: David Cassany [email protected]