-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /etc/hosts file back #384
Conversation
mmm while I am totally in favor to get back After second look I believe #366 mostly fails because it should have been - ^/tmp/.*
- ^/proc/.*
- ^/sys/.*
- ^/run/.*
- ^/dev/.* instead of - ^/tmp
- ^/proc
- ^/sys
- ^/run
- ^/dev some of these folders, if not all, are part of the readonly image, so at boot systemd can't create mountpoint. |
Good point, but for the purpose of #366 excluding its content is not enough, luet will try to That being said, I can try to add nevertheless - ^/tmp/.*
- ^/proc/.*
- ^/sys/.*
- ^/run/.*
- ^/dev/.* to the excludes of |
07ec3c4
to
6b56092
Compare
@davidcassany added in 6b56092 👍 |
I am not sure about /dev folder though... Probably I'd start without this one. |
Sure! I don't think anyhow we are recreating any of them with mknod, so should be safe |
ok, something is not ok by excluding those files, I'll split that in a separate PR |
While it fixes things for from scratch installs, it breaks many things: - we should generate an /etc/hosts file during boot, ideally in cloud-init phase, but that looks cumbersome as we can just relay on what's the default - going to that route, and then excluding /proc, /sys, /run and /tmp requires further work on the bootstrap part, currently tests are not passing (see #366) It sounds easier instead to have a separate package for it just for creating derivatives "from scratch" - in that way we don't interfere with the standard system/cos which is supposed to run on ISO and other medium too, where such folders are mandatory. This addition adds a system/cos-container to just provide a separate package with /proc, /run, /sys, /dev, /tmp stripped which is meant to be used for from scratch scenarios. Supersedes: #366 Signed-off-by: Ettore Di Giacinto <[email protected]>
All required tests are passing, merging |
) This commit instead of swallowing viper errors when loading config files it reports back the error for build commands. This is the same criteria as it is for the run time commands. Signed-off-by: David Cassany <[email protected]>
While it fixes things for from scratch installs, it breaks many things:
cloud-init phase, but that looks cumbersome as we can just relay on
what's the default
requires further work on the bootstrap part, currently tests are not
passing (see Exclude /proc and /sys #366)
It sounds easier instead to have a separate package for it just for
creating derivatives "from scratch" - in that way we don't interfere
with the standard system/cos which is supposed to run on ISO and other
medium too, where such folders are mandatory.
This addition adds a system/cos-container to just provide a separate package
with /proc, /run, /sys, /dev, /tmp stripped which is meant to be used for
from scratch scenarios.
Supersedes: #366
Signed-off-by: Ettore Di Giacinto [email protected]