Add option to enable/disable upx compression #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #356 Signed-off-by: Ettore Di Giacinto <[email protected]>
davidcassany
reviewed
Jul 2, 2021
There was a problem hiding this comment.
LGTM 👍
As mentioned in #356, I'd set it to false for a while and after some days we will easily see if the failure is gone. Beyond that I like this little extra flexibility, so we can super easily change it at our convenience.
davidcassany
approved these changes
Jul 2, 2021
|
nonsquashfs passing. Not sure why all of a sudden we are seeing all squash tests red |
frelon
pushed a commit
to frelon/elemental-toolkit
that referenced
this pull request
May 12, 2023
Signed-off-by: Itxaka <[email protected]> Signed-off-by: Itxaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #356 - it also disables it
Signed-off-by: Ettore Di Giacinto [email protected]