Re-enable recovery upgrade test #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
force-pushed
the
re_enable_test
branch
2 times, most recently
from
01770f4
to
f20f15c
Compare
We had to disable this because we didn't had published changes supporting the scenario. Also fix up a leftover from rebases that slipped through an automatic PR merge. Signed-off-by: Ettore Di Giacinto <[email protected]>
Itxaka
reviewed
Jun 24, 2021
| @@ -160,19 +160,24 @@ upgrade() { | |||
| export LUET_PRIVILEGED_EXTRACT=true | |||
|
|
|||
| args="" | |||
| if [ -z "$VERIFY" ]; then | |||
| args="--enable-logfile --logfile /tmp/luet.log --plugin image-mtree-check" | |||
| if [ -z "$VERIFY" ] || [ "$VERIFY" == true ]; then | |||
There was a problem hiding this comment.
Is there something that sets this var to true?
There was a problem hiding this comment.
it could be set to true if someone sets it in the /etc/cos-upgrade-image file, that file gets sourced to be able to set custom behavior of cos-upgrade by default
Itxaka
reviewed
Jun 24, 2021
| if [ -n "$CHANNEL_UPGRADES" ] && [ "$CHANNEL_UPGRADES" == true ]; then | ||
| echo "Upgrading from release channel" | ||
| set -x |
There was a problem hiding this comment.
Is this a leftover from debugging?
There was a problem hiding this comment.
yes/no.. I've added it for debugging, but I'm unsure to keep it or not. It seems useful for debug, but also as a informative output of what's going on.. UX definetly deserve its own story :)
Itxaka
approved these changes
Jun 24, 2021
frelon
pushed a commit
to frelon/elemental-toolkit
that referenced
this pull request
May 12, 2023
Signed-off-by: David Cassany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to disable this because we didn't had published changes
supporting the scenario.
It also fixes a leftover from a rebase that I believe slipped from the merges due to the automatic PR merge features (seems it is flaky and catches success early if there are no results back from the CI yet.. 🤷 )
Signed-off-by: Ettore Di Giacinto [email protected]