You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
atm the bot logic to bundle the orders is that it loops over each order's inputs and outputs and gather each combination based on the token pair into an array of objects with top fields holding the tokens pair details(address, symbol, decimals) and an array of takeOrders each having the order id and takeOrder struct + IOIndexes that can be consumed by the arb() method.
this process will still take place for when bundliing is not selected as an option. which is not necessarily needed in case of processing one order at the a time and is only kept to have an unified object format for bundling/no bunlding cases.
one of the main issues with nested loops like above is that they are highly cyclomatic and hard to test, this needs to reviewed and refactored in a way that addresses the issues mentioned above, ie make it easier to test which as a result would make things more secure as well as possibly refactoring it with a better design that is less bug prone.
The text was updated successfully, but these errors were encountered:
atm the bot logic to bundle the orders is that it loops over each order's inputs and outputs and gather each combination based on the token pair into an array of objects with top fields holding the tokens pair details(address, symbol, decimals) and an array of
takeOrders
each having the orderid
andtakeOrder
struct +IOIndexes
that can be consumed by thearb()
method.this process will still take place for when bundliing is not selected as an option. which is not necessarily needed in case of processing one order at the a time and is only kept to have an unified object format for bundling/no bunlding cases.
one of the main issues with nested loops like above is that they are highly cyclomatic and hard to test, this needs to reviewed and refactored in a way that addresses the issues mentioned above, ie make it easier to test which as a result would make things more secure as well as possibly refactoring it with a better design that is less bug prone.
The text was updated successfully, but these errors were encountered: